Minor change to patch upgradeSpec with in-use devices in case they differ from discovered ones #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec if needed. This may be needed when running elemental upgrade in multipathd systems Signed-off-by: Gaurav Mehta <[email protected]>
…wnload, as some 3rd party packages are no longer available. the dependencies are already vendored so build wil leverage the same Signed-off-by: Gaurav Mehta <[email protected]>
Signed-off-by: Gaurav Mehta <[email protected]>
Do not execute test-deps target on PRs, the test is outdated on old branches. Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
Contributor
Author
|
@ibrokethecloud I would appreciate if you could verify this PR is still solving the use case you were trying to fix. I did few minimalist changes to your patch which should be transparent (using internal |
Contributor
|
on a test node using multipath devices using a build from the PR, I was able to complete an upgrade, the upgrade config gets updated to use the multipath'd devices |
Contributor
Author
Perfect! Then I am merging it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multipathing is enabled, the OS boots off the multipath /dev/mapper device
During upgrade elemental uses
jaypipes/ghwto find block devices from/sys/blocktree.This misses the multipath partitions, which can cause issue #2299
The PR introduces a minor change where once the UpgradeSpec is generated from parsing of
/sys/blocktree we lookup the result ofblkid -L $LABELto identify partition with label.This will result in the multipath partition being returned
For example from a sample multipath'd host
If the partition does not match the one generated from parsing
/sys/blockthen we update the upgrade spec to use the newly found partition.This PR is including all commits from #2300 and including few additional commits to fix and adapt unit and integration tests.
Fixes #2299